Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix azure.IsNotFound for new azcore error type #3842

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

thomas11
Copy link
Contributor

@thomas11 thomas11 commented Jan 9, 2025

Fixes an issue I discovered today when trying to reproduce another issue report. pulumi refresh is broken for this provider:

$ PATH="$HOME/pulumi/pan/bin:$PATH" pulumi refresh --skip-preview -s dev

     pulumi:pulumi:Stack                      recoveryservices-protecteditem-dev  **failed**                1 error; 4 warnings
 ~   ├─ azure-native:resources:ResourceGroup  resourceGroup                       **refreshing failed**     1 error

  azure-native:resources:ResourceGroup (resourceGroup):
    error: Code="ResourceGroupNotFound" Message="Resource group 'resourceGroup3f871416' could not be found."

The reason is that #3783 regressed azure.IsNotFound, causing Read to report an error when a resource doesn't exist in Azure.

This PR fixes the problem and adds test coverage.

Copy link

github-actions bot commented Jan 9, 2025

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@thomas11 thomas11 force-pushed the tkappler/azcore-isnotfound branch from 3c330f6 to 2dfd03c Compare January 9, 2025 17:52
@thomas11 thomas11 merged commit d40719a into master Jan 10, 2025
21 checks passed
@thomas11 thomas11 deleted the tkappler/azcore-isnotfound branch January 10, 2025 06:47
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v2.82.0.

@thomas11 thomas11 added impact/regression Something that used to work, but is now broken area/providers labels Jan 13, 2025
@mjeffryes mjeffryes removed the impact/regression Something that used to work, but is now broken label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants